Skip to content

NRF: Fix ThreadDebug on Nano 33 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2021
Merged

NRF: Fix ThreadDebug on Nano 33 #141

merged 1 commit into from
Feb 19, 2021

Conversation

iabdalkader
Copy link
Contributor

  • ThreadDebug does Not work with the debugging monitor disabled.
  • Update the comment to reflect what this patch is doing exactly.

@iabdalkader
NRF: Fix ThreadDebug on Nano 33
c1abdc9 
* ThreadDebug does Not work with the debugging monitor disabled.
* Update the comment to reflect what this patch is doing exactly.
@github-actions
Copy link

Memory usage change @ c1abdc9

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 💚 -64 - 0 -0.01 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board libraries/Scheduler/examples/MultipleBlinks
flash		 % libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		 % libraries/doom/examples/Doom
flash		 % libraries/doom/examples/Doom
RAM for global variables		 % libraries/KernelDebug/examples/KernelDebug
flash		 % libraries/KernelDebug/examples/KernelDebug
RAM for global variables		 % libraries/Portenta_SDCARD/examples/TestSDCARD
flash		 % libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		 % libraries/Portenta_Video/examples/Envie_video_coreboot
flash		 % libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
flash		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
flash		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
RAM for global variables		 % libraries/ThreadDebug/examples/ThreadDebug
flash		 % libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		 % libraries/USBHOST/examples/KeyboardController
flash		 % libraries/USBHOST/examples/KeyboardController
RAM for global variables		 % libraries/USBHOST/examples/Shell
flash		 % libraries/USBHOST/examples/Shell
RAM for global variables		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
flash		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
RAM for global variables		 % libraries/PDM/examples/PDMSerialPlotter
flash		 % libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		 %
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 -64 -0.01 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>flash,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>flash,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%,libraries/USBHOST/examples/KeyboardController<br>flash,%,libraries/USBHOST/examples/KeyboardController<br>RAM for global variables,%,libraries/USBHOST/examples/Shell<br>flash,%,libraries/USBHOST/examples/Shell<br>RAM for global variables,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>flash,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,-64,-0.01,0,0.0,,,,,,,,,,,,,0,0.0,0,0.0

@pnndra pnndra merged commit 275e2fd into arduino:master Feb 19, 2021
@iabdalkader iabdalkader deleted the nrf_debug_fix branch February 19, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iabdalkader @pnndra